Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare dataset release & docs updates #2126

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from
Open

prepare dataset release & docs updates #2126

wants to merge 9 commits into from

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Dec 9, 2024 •
edited
Loading

Description

Makes dataset interface public and updates transformation and dataaccess snippets in docs to use this interface.

Note: For linting to pass on this PR, ibis dataset accessing must be merged first.

Stuff that happened:

  • Remove sql_client reference in docs where not needed
  • Updated sql_client sql queries to something more useful where it makes sense and added info about accessing data with datasets
  • Reworked the transformations section
  • Currently not yet added any datasets stuff to our quick starts, only to the rest_api tutorial. @rudolfix should I add this there?

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 1fc9891
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67596d3850a1cd0008a99d5c
😎 Deploy Preview https://deploy-preview-2126--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp sh-rp marked this pull request as ready for review December 9, 2024 17:15
rudolfix
rudolfix approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is very good

rudolfix
rudolfix requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's merge ibis first to see if docs will build again.

I'd show how to get data frame in https://dlthub.com/docs/intro "Python data structures" tab - to read content of the table as df

@sh-rp sh-rp mentioned this pull request Dec 11, 2024
Closed
rudolfix
rudolfix reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but let's wait for the final feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh-rp @rudolfix